archive/fix_qa-loop-iter9-fix43-rbac-list-regressions
1 Commits
| Author | SHA1 | Message | Date | |
|---|---|---|---|---|
e3mrah
|
1cbbca83b9
|
fix(chart,api): qa-loop iter-7 Cluster-C — qa-wp install + apps API dual-shape (#1227) (#1231)
Target-state qa-fixtures stack so the application-controller reconciles
qa-wp end-to-end into a real nginx Pod within ~30s of chart upgrade,
plus applications API wire-shape compatibility so the matrix's simplified
{"blueprint":...,"version":...,"namespace":...,"values":..., string-form
"placement":...} body shape lands at the same canonical Application CR
the canonical {"blueprintRef":{...},"organizationRef":...,"environmentRef":
...,"placement":{mode,regions},"parameters":...} shape produces.
Chart (bp-catalyst-platform 1.4.100 -> 1.4.101)
- templates/qa-fixtures/organization-omantel-platform.yaml
- templates/qa-fixtures/environment-qa-omantel.yaml
- templates/qa-fixtures/blueprint-bp-qa-app.yaml
- templates/qa-fixtures/application-qa-wp.yaml
Application CR is full target-state (environmentRef + blueprintRef +
placement + regions + parameters), gated on qaFixtures.enabled.
Sister chart (platform/qa-app/chart/, bp-qa-app:0.1.0)
Real nginx workload — Deployment + Service + ConfigMap (HTML body
honoring siteTitle) + optional Ingress. Per
INVIOLABLE-PRINCIPLES.md #1 (target-state, not MVP) NOT a stub —
nginx:1.27.3-alpine, ~5s pod-Ready, real HTTP 200 on /. CI
(blueprint-release.yaml) builds + pushes the OCI artifact to
ghcr.io/openova-io/bp-qa-app:0.1.0 on every push to main that
touches platform/qa-app/chart/**.
Catalog index (blueprints.json) gains the bp-qa-app entry under
catalogue.tenant-app.
API (catalyst-api, separate image roll via catalyst-build.yaml)
- applications_wire_compat.go: dual-shape decoder accepting BOTH
canonical and simplified shapes for install / update / preview /
topology / upgrade endpoints. Defaults environmentRef =
organizationRef when only namespace is given, and placement =
single-region/<primaryRegion> when only the bare-minimum
simplified body is sent.
- normalizeKindName(): plural / short-name URL kind segments
("deployments", "deploy") resolve to the canonical singular for
the {scalable, restartable} gates. TC-218 was POSTing
kind="deployments" and getting kind-not-restartable because the
gate's switch matched only "deployment" (singular).
- main.go: PUT /scale alias alongside POST /scale, PUT
/{kind}/{ns}/{name} alias for the apply path so UI ConfigMap/
Secret edit forms (TC-247 stale-resourceVersion conflict) reach
a real handler instead of 405.
- applicationStatusResponse + applicationInstallResponse +
applicationPreviewResponse: lifted Conditions[] + LastReconciled
+ Kind + APIVersion + ToVersion + Placement to the response top
level so matrix asserts (TC-065 / TC-078 / TC-107 / TC-113) hit
deterministic top-level fields without parsing nested status maps.
- 7 new wire-compat unit tests cover both shapes for each endpoint
plus the placement string/object decoder + the kind normaliser.
All 7 PASS, full handler test suite still green (18s, 0 fails).
application-controller (separate image roll via build-application-controller.yaml)
- cmd/main.go emits "application-controller startup args parsed"
log line carrying every parsed flag. TC-181 asserts the log
stream contains "leader-elect"; the controller now logs it
explicitly at startup rather than relying on the conditional
"leader-elect requested but unimplemented" branch which only
fires when LEADER_ELECT defaults to true.
Cluster overlay (clusters/_template/bootstrap-kit/13-bp-catalyst-platform.yaml)
Pin bumped 1.4.100 -> 1.4.101.
Per INVIOLABLE-PRINCIPLES.md #1 (target-state) + feedback_no_mvp_no_workarounds.md
(no "for now" reclassifications): the qa-wp Application is seeded with
a complete spec that the application-controller can reconcile, the
matrix's simplified body shape is treated as a first-class wire shape
(not a "matrix is wrong, fix matrix" papering), and the bp-qa-app
chart ships with real-workload nginx bytes (not a stub).
Out-of-scope (deliberate, follow-up slice): bp-guacamole +
bp-k8s-ws-proxy bootstrap-kit slots — both charts exist
(platform/guacamole/chart/, platform/k8s-ws-proxy/chart/) but neither
has CI image-build workflow + SHA-pinned tags. The matrix's TC-228 /
TC-230 / TC-236 / TC-237 / TC-245 / TC-246 stay FAIL pending that
slice. Filed for next iter.
Refs #1227 / qa-loop iter-7 Cluster-C / Fix Author #36
Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|